-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spawn connection-checker
as an unprivileged user
#6656
Conversation
f603283
to
8869e29
Compare
ed0dde2
to
ac7cdf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @dlon)
test/test-runner/src/util.rs
line 84 at r1 (raw file):
log::error!("Failed to restore uid: {error}"); } });
Nice work with the drop guards. They should take care of any bugs if func
panics too, right?
663803c
to
de57355
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @hulthe)
test/test-runner/src/util.rs
line 84 at r1 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
Nice work with the drop guards. They should take care of any bugs if
func
panics too, right?
Yep. Probably not too important in reality, since the runner would crash and (hopefully) be restarted anyway.
de57355
to
b8e3ff3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
Fixes an issue where the connection-checker is allowed to leak traffic on macOS
b8e3ff3
to
283d1eb
Compare
test-runner
now spawns all processes as an unprivileged user.Fix DES-1131
Fix DES-1129
This change is