Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI for shadowsocks obfuscation #6629

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

dlon
Copy link
Member

@dlon dlon commented Aug 16, 2024

Close DES-1145.


This change is Reviewable

@dlon dlon requested a review from Serock3 August 16, 2024 07:36
Copy link

linear bot commented Aug 16, 2024

Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)


CHANGELOG.md line 28 at r1 (raw file):

- Add DAITA (Defence against AI-guided Traffic Analysis) setting for Linux and macOS.
- Add `--json` flag to `mullvad status` CLI.
- Add WireGuard over Shadowsocks obfuscation to the CLI.

Since this is the only way a customer could know about the feature, what do you think about elaborating a bit? Maybe mentioning what command activates it an briefly stating what it does.

E.g. "- New Shadowsocks obfuscation to help connect while under censorship. Currently only available in the CLI by running mullvad obfuscation set shadosocks --port <PORT>"

Or are we expecting the GUI part to be implemented before the next release?

Serock3
Serock3 previously approved these changes Aug 16, 2024
Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)

@dlon dlon force-pushed the add-shadowsocks-obfuscation-cli branch from cf9ab9c to 71aa659 Compare August 26, 2024 08:15
@dlon dlon force-pushed the add-shadowsocks-obfuscation-cli branch from 71aa659 to 7a77d26 Compare August 26, 2024 08:18
Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon merged commit b235a4d into main Aug 26, 2024
50 checks passed
@dlon dlon deleted the add-shadowsocks-obfuscation-cli branch August 26, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants