Fix issues with dns dialog showing wrong state after submitting #6617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pururun
force-pushed
the
adding-custom-dns-briefly-shows-error-on-submit-droid-1230
branch
from
6707eb6 to
ad9d9f5
Compare
albin-mullvad
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Pururun
force-pushed
the
adding-custom-dns-briefly-shows-error-on-submit-droid-1230
branch
from
ad9d9f5 to
b5cb266
Compare
albin-mullvad
force-pushed
the
adding-custom-dns-briefly-shows-error-on-submit-droid-1230
branch
from
b5cb266 to
5f70bee
Compare
albin-mullvad
deleted the
adding-custom-dns-briefly-shows-error-on-submit-droid-1230
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed it so that settings is only fetched at the creation of the dialogue.
This fixes all issues with the state being wrong for a short while after pressing submit.
Tested cases that are fixed:
This change is