-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List only DAITA enabled entry locations in locations view #6609
List only DAITA enabled entry locations in locations view #6609
Conversation
c0839d1
to
2272c98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR also fixes the bug where closing a filter chip in either entry or exit (when multihop is on) doesn't close the other as well.
Reviewable status: 0 of 36 files reviewed, all discussions resolved
01c00b7
to
9076896
Compare
e42edff
to
69be154
Compare
5cd5d21
to
5d337df
Compare
5d337df
to
b5baa95
Compare
b9eb3c8
to
31e7c41
Compare
31e7c41
to
eabf71a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 13 files at r1, all commit messages.
Reviewable status: 12 of 13 files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadVPN/View controllers/SelectLocation/LocationViewController.swift
line 29 at r1 (raw file):
private var filter = RelayFilter() private var selectedRelays: RelaySelection private var daitaEnabled = false
Shouldn't that be passed by via Dependency Injection instead ? (Like it is for LocationViewControllerWrapper
)
eabf71a
to
aa0e997
Compare
aa0e997
to
c0f8355
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 10 of 13 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPN/View controllers/SelectLocation/LocationViewController.swift
line 29 at r1 (raw file):
Previously, buggmagnet wrote…
Shouldn't that be passed by via Dependency Injection instead ? (Like it is for
LocationViewControllerWrapper
)
Indeed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 13 files at r1, 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
c0f8355
to
847e43c
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
When DAITA is enabled, the app should only list DAITA enabled entry locations in the locations view.
If the user has enabled both DAITA & multihop and the relay selector fails to match an entry, when the location view is opened, it should default to showing the entry location view.
This change is