Animate expand in filter screen

[Pururun]

---

This change is 

[linear]

DROID-1212 Improve expand animation for FilterScreen

[Rawa]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/FilterScreen.kt line 260 at r1 (raw file):

        modifier =
            Modifier.fillMaxWidth()
                .clickable(enabled = false, onClick = onApplyClick)

Why do we have this clickable modifier if it is always disabled? Should be removed.

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/FilterScreen.kt line 288 at r1 (raw file):

    const val OWNERSHIP_ALL = "ownership-all"
    const val PROVIDERS_TITLE = "providers-title"
    const val PROVIDERS_ALL = "providers_all"

We should align so they all us - or _, could be worth looking into what has been used previously.

[Pururun]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/FilterScreen.kt line 260 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

Why do we have this clickable modifier if it is always disabled? Should be removed.

Seems like it was a left over of something, removed.

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/FilterScreen.kt line 288 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

We should align so they all us - or _, could be worth looking into what has been used previously.

In select location at least we use _ so I will use that.

[Rawa]

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved