Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align screen and dialog composable names #6467

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Jul 15, 2024

Ensure we don't end with Dialog or Screen on Composables that have @destination annotation since they will append Destination once code has been generated.


This change is Reviewable

Copy link

linear bot commented Jul 15, 2024

@Rawa Rawa force-pushed the align-screen-and-dialog-composable-names-droid-726 branch from c72a2cd to dc181dd Compare July 15, 2024 10:33
@Rawa Rawa self-assigned this Jul 15, 2024
@Rawa Rawa added the Android Issues related to Android label Jul 15, 2024
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 41 of 41 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the align-screen-and-dialog-composable-names-droid-726 branch from ba2a754 to 8eef2e3 Compare July 19, 2024 09:27
@Rawa Rawa force-pushed the align-screen-and-dialog-composable-names-droid-726 branch from 8eef2e3 to 7f616dd Compare July 19, 2024 09:29
@Rawa Rawa merged commit 3a96d56 into main Jul 19, 2024
29 of 30 checks passed
@Rawa Rawa deleted the align-screen-and-dialog-composable-names-droid-726 branch July 19, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants