Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update android gradle plugin version to 8.2.1 #5712

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Jan 22, 2024


This change is Reviewable

@Pururun Pururun requested review from Rawa and albin-mullvad January 22, 2024 14:56
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @Pururun)


android/buildSrc/src/main/kotlin/Versions.kt line 50 at r1 (raw file):

        // The androidAapt plugin version must be in sync with the android plugin version.
        // Required for Gradle metadata verification to work properly, see:
        // https://github.com/gradle/gradle/issues/19228

Did you see this comment?

Code quote:

        // The androidAapt plugin version must be in sync with the android plugin version.
        // Required for Gradle metadata verification to work properly, see:
        // https://github.com/gradle/gradle/issues/19228

@Pururun Pururun added the Android Issues related to Android label Jan 23, 2024
@Pururun Pururun force-pushed the upgrade-gradle-plugin-8-2 branch from e0eee22 to b2ed271 Compare January 23, 2024 11:38
Copy link
Contributor Author

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)


android/buildSrc/src/main/kotlin/Versions.kt line 50 at r1 (raw file):

Previously, albin-mullvad wrote…

Did you see this comment?

Yes and as far as I can tell it uses the same trailing number:
https://mvnrepository.com/artifact/com.android.tools.build/aapt2/8.2.0-10154469

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


android/buildSrc/src/main/kotlin/Versions.kt line 50 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Yes and as far as I can tell it uses the same trailing number:
https://mvnrepository.com/artifact/com.android.tools.build/aapt2/8.2.0-10154469

Yeah, looks like that 👍

@Pururun Pururun force-pushed the upgrade-gradle-plugin-8-2 branch from b2ed271 to aa883e8 Compare January 24, 2024 08:00
@Pururun Pururun merged commit f4d2f44 into main Jan 24, 2024
17 checks passed
@Pururun Pururun deleted the upgrade-gradle-plugin-8-2 branch January 24, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants