Add target_os attribute to test framework
#5650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPettersson98
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
dlon
force-pushed
the
add-os-specific-tests
branch
from
8b0f844 to
1acf4fb
Compare
dlon
force-pushed
the
add-os-specific-tests
branch
from
1acf4fb to
13b25f7
Compare
dlon
force-pushed
the
add-os-specific-tests
branch
from
13b25f7 to
3b312da
Compare
MarkusPettersson98
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to write tests that only run on a specific OS, either Linux, macOS, or Windows. The "OS under test" was also moved to
TEST_CONFIG, since it's a constant and we know it in advance.Closes DES-533.
This change is