-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Linux build container (Golang 1.21.3 and Rust 1.75) #5645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
building/README.md
line 36 at r1 (raw file):
# Pushes the new sigstore entry GIT_SSH_COMMAND="ssh -i /path/to/deploy-key" git push
FYI: The build server has a bunch of ssh credentials. And by default ssh does not use the deploy key for this repository. So we need to explicitly tell it to do that. I forget this on every new container build and need to figure out what's wrong. Adding it to the docs should save some time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
building/README.md
line 36 at r1 (raw file):
Previously, faern (Linus Färnstrand) wrote…
FYI: The build server has a bunch of ssh credentials. And by default ssh does not use the deploy key for this repository. So we need to explicitly tell it to do that. I forget this on every new container build and need to figure out what's wrong. Adding it to the docs should save some time.
Sounds good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faern)
a discussion (no related file):
Might be nice to bump android image in the same PR 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faern)
a discussion (no related file):
Previously, albin-mullvad wrote…
Might be nice to bump android image in the same PR 🤔
Basically combining this PR with the following PR since it's a bit incomplete otherwise: #5649
One example is that some desktop workflows should be bumped to use the same rust version as the container.
29e8cc3
to
f6b633a
Compare
Superseded by #5559 |
This change is