Remove unused dependencies

[Pururun]

---

This change is 

[linear]

DROID-552 Remove unused dependencies

Use The Dependency Analysis Gradle Plugin (DAGP) to find any unused dependencies and remove them.

This part of the weekly code cleanup task.

[Rawa]

Reviewed 7 of 8 files at r1, all commit messages.
Reviewable status: 7 of 8 files reviewed, 2 unresolved discussions (waiting on @Pururun)

---

android/app/build.gradle.kts line 343 at r1 (raw file):

    implementation(Dependencies.Koin.core)
    implementation(Dependencies.Koin.android)
    implementation(Dependencies.Koin.compose)

I believe this one should be kept, it is used by the new navigation PR.

---

android/service/build.gradle.kts line 54 at r1 (raw file):

    implementation(project(Dependencies.Mullvad.ipcLib))
    implementation(project(Dependencies.Mullvad.modelLib))
    implementation(project(Dependencies.Mullvad.resourceLib))

Since it handles the notifications shouldn't it also need the resourceLib to get its' strings?

[Rawa]

Reviewable status: 7 of 8 files reviewed, 3 unresolved discussions (waiting on @Pururun)

---

android/buildSrc/src/main/kotlin/Dependencies.kt line 0 at r1 (raw file):
We have some weird additions in this file even though we made just removals from the dependencies, @albin-mullvad can you double check to see if the file would be the same for you?

[Rawa]

Reviewable status: 7 of 8 files reviewed, 3 unresolved discussions (waiting on @Pururun)

---

android/service/build.gradle.kts line 54 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

Since it handles the notifications shouldn't it also need the resourceLib to get its' strings?

Seems like this gets retrieved through commonLib. Should we keep it for clarify or not?

[Pururun]

Reviewable status: 5 of 8 files reviewed, 3 unresolved discussions (waiting on @Rawa)

---

android/app/build.gradle.kts line 343 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

I believe this one should be kept, it is used by the new navigation PR.

Done

[Rawa]

Reviewed 5 of 5 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

[Rawa]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

[Pururun]

Reviewable status: 4 of 8 files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

android/buildSrc/src/main/kotlin/Dependencies.kt line at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

We have some weird additions in this file even though we made just removals from the dependencies, @albin-mullvad can you double check to see if the file would be the same for you?

I managed to run the update lock file script in docker. @albin-mullvad can you verify that the output is correct?

[albin-mullvad]

Reviewed 3 of 8 files at r1, 1 of 5 files at r3, 4 of 4 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/buildSrc/src/main/kotlin/Dependencies.kt line at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

I managed to run the update lock file script in docker. @albin-mullvad can you verify that the output is correct?

I've verified that it looks correct by re-generating the lockfile locally.

[Pururun]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

---

android/service/build.gradle.kts line 54 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

Seems like this gets retrieved through commonLib. Should we keep it for clarify or not?

I think we can keep resourceLib for clarity, what do you think @albin-mullvad ?

[Pururun]

Reviewable status: complete! all files reviewed, all discussions resolved

---

android/service/build.gradle.kts line 54 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

I think we can keep resourceLib for clarity, what do you think @albin-mullvad ?

After discussion with @albin-mullvad we decided to remove it as it would make it easier to use such tools in the future.