Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform to download urls #5197

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

raksooo
Copy link
Member

@raksooo raksooo commented Sep 27, 2023

This PR adds support for including the platform in the download url to make it work with spoofed user agents.


This change is Reviewable

@linear
Copy link

linear bot commented Sep 27, 2023

DES-372 Open download urls for correct platform

Mullvad Browser can't detect the platform so we want to solve this be opening the download page for the correct platform from the app.

The URLs should be:
Hank said:

Stable:

[http://mullvad.net/download/vpn/{ios%7Candroid%7Cmacos%7Clinux%7Cwindows}|mullvad.net/download/vpn/{ios|android|macos|linux|windows}](http://mullvad.net/download/vpn/{ios%7Candroid%7Cmacos%7Clinux%7Cwindows}|mullvad.net/download/vpn/{ios|android|macos|linux|windows})

Beta:

<http://mullvad.net/download/vpn/{ios%7Candroid%7Cmacos%7Clinux%7Cwindows}#beta|mullvad.net/download/vpn/{ios|android|macos|linux|windows}#beta>

@raksooo raksooo force-pushed the open-download-urls-for-correct-platform-des-372 branch 2 times, most recently from 2ffa025 to a150527 Compare September 27, 2023 13:09
@raksooo raksooo requested a review from dlon September 27, 2023 13:10
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@raksooo raksooo force-pushed the open-download-urls-for-correct-platform-des-372 branch from a150527 to 11942b1 Compare September 28, 2023 11:10
@raksooo raksooo merged commit f5eaa62 into main Sep 28, 2023
4 checks passed
@raksooo raksooo deleted the open-download-urls-for-correct-platform-des-372 branch September 28, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants