Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially revert "Remove android file migration" #5194

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

albin-mullvad
Copy link
Collaborator

@albin-mullvad albin-mullvad commented Sep 25, 2023

This PR aims to restore the relays.json asset->file extraction that was removed by accident in #4449. The remaining file migration logic will not be re-introduced.

This partially reverts commit e64abbb.


This change is Reviewable

@linear
Copy link

linear bot commented Sep 25, 2023

DROID-363 Bundled relay list unused due to missing asset extraction

Given the user has a fresh install of the app and create a new account the port ranges and relay list will be empty.

@albin-mullvad albin-mullvad self-assigned this Sep 25, 2023
@albin-mullvad albin-mullvad added bug Android Issues related to Android labels Sep 25, 2023
Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

This commit aims to restore the `relays.json` asset->file
extraction that was removed by accident in the partially
reverted commit. The actual file migration logic will not
be re-introduced.

This partially reverts commit e64abbb.
@albin-mullvad albin-mullvad force-pushed the fix-unused-bundled-relay-list-droid-363 branch from a13150c to b9c814f Compare September 26, 2023 10:11
@albin-mullvad albin-mullvad merged commit c9deafb into main Sep 26, 2023
10 checks passed
@albin-mullvad albin-mullvad deleted the fix-unused-bundled-relay-list-droid-363 branch September 26, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants