Set default dialog radius to 11 and apply it to all dialogs #5186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DROID-358 Set dialog radius to the correct value
Currently most dialogs have the radius set to 4, it should be 11 (or some other yet to be determined value) Also some dialogs does not have any radius at all. We should add radius to these. |
Pururun
force-pushed
the
set-dialog-radius-to-the-correct-value-droid-358
branch
from
2883d84 to
534de03
Compare
|
Looks good code-wise and when I compared the result with the design documents 👍 Would be great if @mullmat also can double-check that it's correct since there has been a lot of back and forth with these dialogs. |
albin-mullvad
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Pururun
force-pushed
the
set-dialog-radius-to-the-correct-value-droid-358
branch
from
534de03 to
9a3b718
Compare
Pururun
deleted the
set-dialog-radius-to-the-correct-value-droid-358
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is