Add social media blocklists to daemon+CLI #5163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
force-pushed
the
add-daemoncli-support-for-social-media-blocklist-des-354
branch
from
d92b40a to
cee733e
Compare
dlon
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
|
Will be available on all VPN servers tomorrow afternoon. |
faern
force-pushed
the
add-daemoncli-support-for-social-media-blocklist-des-354
branch
2 times, most recently
from
36ab1de to
73c0f58
Compare
There was a problem hiding this comment.
Reviewed 1 of 6 files at r1, 1 of 1 files at r2.
Reviewable status:
When infra has deployed these block lists to the relays, this setting will allow blocking social media domains directly with the app
faern
force-pushed
the
add-daemoncli-support-for-social-media-blocklist-des-354
branch
from
73c0f58 to
412b799
Compare
faern
deleted the
add-daemoncli-support-for-social-media-blocklist-des-354
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When infra has deployed these block lists to the relays, this setting will allow blocking social media domains directly with the app.
I intentionally left it out of the changelog for now. This should not go into production before it's added to the UI anyway.
This change is