Fix dialogs padding and spacing

[Rawa]

Fixes inconsistencies between different dialogs and aligns it closer to the current design.

---

This change is 

[linear]

DROID-314 fix settings dialogs' padding and spacing

Several of the dialogs have the wrong spacing compared to the design

[sabercodic]

Reviewed 9 of 13 files at r1, 3 of 4 files at r3, all commit messages.
Reviewable status: 12 of 13 files reviewed, 2 unresolved discussions (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/List.kt line 152 at r3 (raw file):

@Composable
fun ChangeListItem(text: String) {
    val smallPadding = Dimens.smallPadding

If there is just one usage for this just use it directly instead of define variable

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/QuantumResistanceInfoDialog.kt line 10 at r3 (raw file):

@Preview
@Composable
fun PreviewQuantumResistanceInfoDialog() {

make previews scope private. it applies for all previews

[Pururun]

Reviewed 1 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/ChangelogDialog.kt line 45 at r3 (raw file):

                modifier = Modifier.fillMaxWidth(),
                verticalArrangement =
                    Arrangement.spacedBy(dimensionResource(id = R.dimen.small_padding))

Should use Dimens.smallPadding instead.

[Rawa]

Reviewable status: 2 of 13 files reviewed, 3 unresolved discussions (waiting on @Pururun and @sabercodic)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/List.kt line 152 at r3 (raw file):

Previously, sabercodic wrote…

If there is just one usage for this just use it directly instead of define variable

Done.

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/ChangelogDialog.kt line 45 at r3 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Should use Dimens.smallPadding instead.

Done.

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/QuantumResistanceInfoDialog.kt line 10 at r3 (raw file):

Previously, sabercodic wrote…

make previews scope private. it applies for all previews

Good catch! 👍

[Pururun]

Reviewed 11 of 11 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @sabercodic)

[albin-mullvad]

Reviewed 12 of 13 files at r1, 2 of 4 files at r3, 10 of 11 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @sabercodic)

[sabercodic]

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions

[sabercodic]

Reviewable status: all files reviewed, 2 unresolved discussions

[Pururun]

Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions