Device list resets after going to settings

[Pururun]

This is because the device list is not updated unless specifically told so.

Added so that it always updates on successful device list events.

Also improved the compose view.

---

This change is 

[linear]

DROID-194 Device list resets after going to settings

After clicking on settings and then going back to the too many devices screen the list is reset as it was when it was first opened, regardless if the user have removed any devices.

Steps to reproduce:

1. Remove a device from the device list
2. Open settings by click on the cog in the upper right corner
3. Close settings
4. Note that the removed device is back in the device list.

[Rawa]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/DeviceRepository.kt line 60 at r1 (raw file):

            .map {
                if (it is DeviceListEvent.Available) {
                    cachedDeviceList.value = DeviceList.Available(it.devices)

I believe this fix is fine for now but we should probably revisit/reimagine how the DeviceRepository works, it feels unnaturally complex with multiple streams containing deviceList, deviceState, deviceRemovalEvent etc.

[albin-mullvad]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/DeviceRepository.kt line 60 at r1 (raw file):

            .map {
                if (it is DeviceListEvent.Available) {
                    cachedDeviceList.value = DeviceList.Available(it.devices)

This is probably find, but did you test various cases to check whether this cache works as expected? For instance to make sure that the cache never is used in the wrong situation, e.g. if the user tries to log in to another account (and an updated device list fails to be fetched).

Code quote:

cachedDeviceList.value = DeviceList.Available(it.devices)

[albin-mullvad]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/DeviceRepository.kt line 60 at r1 (raw file):

Previously, albin-mullvad wrote…

This is probably find, but did you test various cases to check whether this cache works as expected? For instance to make sure that the cache never is used in the wrong situation, e.g. if the user tries to log in to another account (and an updated device list fails to be fetched).

probably fine*

[Pururun]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/DeviceRepository.kt line 60 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

I believe this fix is fine for now but we should probably revisit/reimagine how the DeviceRepository works, it feels unnaturally complex with multiple streams containing deviceList, deviceState, deviceRemovalEvent etc.

Yes agree, very unnecessarily complex.

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/DeviceRepository.kt line 60 at r1 (raw file):

Previously, albin-mullvad wrote…

probably fine*

I have tested logging in to a different account, but not where an updated list fails to fetch.

[albin-mullvad]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/DeviceRepository.kt line 60 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

I have tested logging in to a different account, but not where an updated list fails to fetch.

Can that scenario also be tested either manually or/and using automated tests? Otherwise this one looks ready to merge.

[Pururun]

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad and @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/DeviceRepository.kt line 60 at r1 (raw file):

Previously, albin-mullvad wrote…

Can that scenario also be tested either manually or/and using automated tests? Otherwise this one looks ready to merge.

Tested it manually and it seems to work fine in that scenario. I think we can merge.

[albin-mullvad]

Reviewed 1 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/DeviceRepository.kt line 60 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Tested it manually and it seems to work fine in that scenario. I think we can merge.

Great! 🚀

[albin-mullvad]

Reviewable status: complete! all files reviewed, all discussions resolved

[Rawa]

Reviewable status: complete! all files reviewed, all discussions resolved