Fix or report all current swiftlint warnings in xcode #5100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IOS-296 Fix Swiftlint warnings in Xcode
Go through the existing warnings and either fix them or disable + report them (in Linear). |
rablador
commented
Sep 4, 2023
There was a problem hiding this comment.
For the [weak self] caption warnings, see discussion in Linear: https://mullvad.slack.com/archives/C052D9X882U/p1693834413327759
I opted to go for guard let self = self and no explicit self in closure. Can easily be changed if other way is preferred.
Reviewable status: 0 of 48 files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to go through the existing lint warnings and either fix them or disable + report them (in Linear).
This change is