Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forwarded ports on iOS #5078

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Remove forwarded ports on iOS #5078

merged 1 commit into from
Sep 4, 2023

Conversation

pronebird
Copy link
Contributor

@pronebird pronebird commented Aug 31, 2023

In sympathy with #5074, it's time to drop forwarded ports as those were decommissioned anyway.


This change is Reviewable

@pronebird pronebird added the iOS Issues related to iOS label Aug 31, 2023
@pronebird pronebird requested a review from buggmagnet August 31, 2023 14:39
@linear
Copy link

linear bot commented Aug 31, 2023

IOS-288 Drop forwarded ports

RESTTypes still references Port structure and ports: [Port] field in Device. Since support for ports was decommissioned, we should drop those types and fields from our codebase.

@pronebird pronebird force-pushed the remove-ports-ios-288 branch from 4282b18 to 3bb9a41 Compare September 4, 2023 08:32
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: 0 of 3 files reviewed, all discussions resolved

@pronebird pronebird force-pushed the remove-ports-ios-288 branch from 3bb9a41 to d1ea221 Compare September 4, 2023 10:09
@pronebird pronebird merged commit d6e0c53 into main Sep 4, 2023
4 checks passed
@pronebird pronebird deleted the remove-ports-ios-288 branch September 4, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants