Move out of time behaviour to view model #5049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DROID-289 Move out of time behaviour to view model
Current out of time behaviour could be moved to the viewModel and removed from fragment. |
Pururun
changed the title
Pururun
force-pushed
the
move-out-of-time-behaviour-to-view-model-droid-289
branch
3 times, most recently
from
6332405 to
24656f4
Compare
Pururun
force-pushed
the
move-out-of-time-behaviour-to-view-model-droid-289
branch
3 times, most recently
from
56194f4 to
5bf7c30
Compare
albin-mullvad
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Pururun
force-pushed
the
move-out-of-time-behaviour-to-view-model-droid-289
branch
from
5bf7c30 to
1e488e5
Compare
Pururun
deleted the
move-out-of-time-behaviour-to-view-model-droid-289
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour is in the fragment, since we want to remove fragments I have moved it to the viewModel.
This replicate the view action pattern that is used elsewhere and in the other connect PR.
This change is