Skip to content

Commit

Permalink
Add reminder to update test on new indicators
Browse files Browse the repository at this point in the history
  • Loading branch information
Serock3 authored and dlon committed Aug 21, 2024
1 parent 5ff930f commit e2c7d16
Showing 1 changed file with 21 additions and 2 deletions.
23 changes: 21 additions & 2 deletions mullvad-types/src/features.rs
Original file line number Diff line number Diff line change
Expand Up @@ -225,11 +225,11 @@ mod tests {
expected_indicators
);

// Setting mssfix without having an openVPN endpoint should not result in an indicator
settings.tunnel_options.openvpn.mssfix = Some(1300);
assert_eq!(
compute_feature_indicators(&settings, &endpoint),
expected_indicators
expected_indicators,
"Setting mssfix without having an openVPN endpoint should not result in an indicator"
);

endpoint.tunnel_type = TunnelType::OpenVpn;
Expand Down Expand Up @@ -319,5 +319,24 @@ mod tests {
expected_indicators
);
}

// NOTE: If this match statement fails to compile, it means that a new feature indicator has
// been added. Please update this test to include the new feature indicator.
match FeatureIndicator::QuantumResistance {
FeatureIndicator::QuantumResistance => {}
FeatureIndicator::Multihop => {}
FeatureIndicator::BridgeMode => {}
FeatureIndicator::SplitTunneling => {}
FeatureIndicator::LockdownMode => {}
FeatureIndicator::Udp2Tcp => {}
FeatureIndicator::Shadowsocks => {}
FeatureIndicator::LanSharing => {}
FeatureIndicator::DnsContentBlockers => {}
FeatureIndicator::CustomDns => {}
FeatureIndicator::ServerIpOverride => {}
FeatureIndicator::CustomMtu => {}
FeatureIndicator::CustomMssFix => {}
FeatureIndicator::Daita => {}
}
}
}

0 comments on commit e2c7d16

Please sign in to comment.