Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

fix unit-test #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix unit-test #1

wants to merge 1 commit into from

Conversation

joaosamouco
Copy link

Object keys order is not guaranteed, please refer to section 9.1.11.

Return an Iterator object (25.1.1.2) whose next method iterates over all the String-valued keys of enumerable properties of O. The Iterator object must inherit from %IteratorPrototype% (25.1.2). The mechanics and order of enumerating the properties is not specified but must conform to the rules specified below.

The previous unit-test implementation was not likely to fail when not using Property Keys Reordering but the implementation I'm proposing takes into account the fact that the properties key order is not guaranteed by all browsers; will not fail even when using Property Keys Reordering; and also I'm assuming that the order of the query part string is not relevant for you.

@blai
Copy link
Contributor

blai commented May 16, 2017

I think this is acceptable because we are not likely be relying on the ordering in this case, but I will take notes on this when this behavior causes other issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants