Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPro] Use Set for detailPanelExpandedRowIds #15835

Merged
merged 17 commits into from
Dec 16, 2024

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Dec 10, 2024

Addresses #15627 (comment)

Changelog

Breaking changes

  • detailPanelExpandedRowIds and onDetailPanelExpandedRowIdsChange props use Set instead of an array:

    -detailPanelExpandedRowIds?: GridRowId[];
    +detailPanelExpandedRowIds?: Set<GridRowId>;
    
    -onDetailPanelExpandedRowIdsChange?: (ids: GridRowId[], details: GridCallbackDetails) => void;
    +onDetailPanelExpandedRowIdsChange?: (ids: Set<GridRowId>, details: GridCallbackDetails) => void;
  • apiRef.current.getExpandedDetailPanels and apiRef.current.setExpandedDetailPanels methods receive and return Set instead of an array.

  • gridDetailPanelExpandedRowIdsSelector returns Set instead of an array.

  • gridDetailPanelExpandedRowsHeightCacheSelector was removed.

@cherniavskii cherniavskii added performance breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Master-detail Related to the data grid Master-detail feature labels Dec 10, 2024
@mui-bot
Copy link

mui-bot commented Dec 10, 2024

@cherniavskii cherniavskii requested a review from romgrk December 13, 2024 12:29
@cherniavskii cherniavskii marked this pull request as ready for review December 13, 2024 12:29
@cherniavskii cherniavskii merged commit 45e01cf into mui:master Dec 16, 2024
18 checks passed
@cherniavskii cherniavskii deleted the detail-panel-set branch December 16, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Master-detail Related to the data grid Master-detail feature performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants