-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[codemod] Add missing preset-safe
for the data-grid
#15709
Conversation
Deploy preview: https://deploy-preview-15709--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refinement. 👍
P.S. WDYT about using the codemod
prefix for the PR?
It directly impacts the package. 🤔
I have used the linked PR as a reference (same situation), I don't mind having it either way |
Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Armin Mehinovic <[email protected]>
preset-safe
for the data-gridpreset-safe
for the data-grid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👌
Thanks for the adjustments. 💯 🙏
Adds missing
preset-safe
for the data grid#15659 helped detect that
I have added pickers section to the readme
Also, I have aligned formatting for the diffs in the readme (spacing for changed and unchanged lines)