[TreeView] Fix drag and drop issue with label editing #15636
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noraleonte
added
bug 🐛
|
Deploy preview: https://deploy-preview-15636--material-ui-x.netlify.app/ |
| @@ -7,6 +7,7 @@ import { | |||
| isTargetInDescendants, | |||
| useSelector, | |||
| } from '@mui/x-tree-view/internals'; | |||
| import { selectorIsItemBeingEdited } from '@mui/x-tree-view/internals/plugins/useTreeViewLabel/useTreeViewLabel.selectors'; | |||
There was a problem hiding this comment.
This one has to be exported from internals/index.ts
| @@ -34,6 +36,9 @@ export const useTreeViewItemsReorderingItemPlugin: TreeViewItemPlugin = ({ props | |||
| itemId, | |||
| ); | |||
| const isValidTarget = useSelector(store, selectorItemsReorderingIsValidTarget, itemId); | |||
| const draggedItemId = useSelector(store, selectorDraggedItem); | |||
|
|
|||
| const isBeingEdited = useSelector(store, selectorIsItemBeingEdited, draggedItemId as string); | |||
There was a problem hiding this comment.
Suggested change
| const isBeingEdited = useSelector(store, selectorIsItemBeingEdited, draggedItemId as string); | |
| If `draggedItemId` can be null, you can do: | |
| const isBeingEdited = useSelector( | |
| store, | |
| state => draggedItemId == nul ? false : selectorIsItemBeingEdited(draggedItemId), | |
| ); |
Or you can update selectorIsItemBeingEdited to support null, which would make sense to me as well.
| /** | ||
| * Get the id of the item that is currently being dragged. | ||
| * @param {TreeViewState<[UseTreeViewItemsReorderingSignature]>} state The state of the tree view. | ||
| * @returns {string} The id of the currently dragged item. |
There was a problem hiding this comment.
This seems to be missing null
| */ | ||
| export const selectorDraggedItem = createSelector( | ||
| [selectorItemsReordering], | ||
| (itemsReordering) => itemsReordering && itemsReordering.draggedItemId, |
There was a problem hiding this comment.
Suggested change
| (itemsReordering) => itemsReordering && itemsReordering.draggedItemId, | |
| (itemsReordering) => itemsReordering?.draggedItemId |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15533