v8.0.0-alpha.1 #15554
Merged
v8.0.0-alpha.1 #15554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
requested review from
LukasTy,
MBilalShafi,
romgrk,
flaviendelangle,
arminmeh,
arthurbalduini,
noraleonte,
JCQuintas,
cherniavskii and
michelengelen
|
Deploy preview: https://deploy-preview-15554--material-ui-x.netlify.app/ |
arminmeh
reviewed
Nov 22, 2024
| - The `tooltip` prop is removed in favor of `slotProps.tooltip` for consistency. | ||
| - The previous slots `popper`, `axisContent`, `itemContent` are removed in favor of a `tooltip` slots which override the entire tooltip. | ||
| - To override the tooltip content, use the `useItemTooltip` or `useAxisTooltip` to get the data, and wrapp your component in `ChartsTooltipContainer` to follow the pointer position. | ||
| - To override the tooltip placement, use the `ChartsItemTooltipContent` or `ChartsItemTooltipContent` to get default data and place them in your custom tooltip. |
There was a problem hiding this comment.
Suggested change
| - To override the tooltip placement, use the `ChartsItemTooltipContent` or `ChartsItemTooltipContent` to get default data and place them in your custom tooltip. | |
| - To override the tooltip placement, use the `<ChartsItemTooltipContent />` or <`ChartsItemTooltipContent />` to get default data and place them in your custom tooltip. |
@samuelsycamore not sure if for those more technical component we want to use the "Charts Item Tooltip Content" or the "<ChartsItemTooltipContent />" for.
There was a problem hiding this comment.
For now, I'm not adding those modification, because their is a lot of technical names, and the < /> make them take more space without adding information
arminmeh
reviewed
Nov 22, 2024
LukasTy
reviewed
Nov 22, 2024
arminmeh
reviewed
Nov 22, 2024
Co-authored-by: Flavien DELANGLE <[email protected]> Co-authored-by: Armin Mehinovic <[email protected]> Signed-off-by: Alexandre Fauquette <[email protected]>
Co-authored-by: Armin Mehinovic <[email protected]> Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Alexandre Fauquette <[email protected]>
Signed-off-by: Alexandre Fauquette <[email protected]>
arminmeh
reviewed
Nov 22, 2024
arminmeh
approved these changes
Nov 22, 2024
alexfauquette
commented
Nov 22, 2024
Co-authored-by: Armin Mehinovic <[email protected]> Signed-off-by: Alexandre Fauquette <[email protected]>
Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Alexandre Fauquette <[email protected]>
|
This release is flagged as "latest" in GitHub, hence shows in https://github.com/mui/mui-x 
I guess this is a mistake. I have updated https://github.com/mui/mui-x/releases/edit/v8.0.0-alpha.1 to flip the checkboxes: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have any idea for the highlight, feel free to add them :)