[Data Grid][core] fix: Entering in edit mode, reload column configuration #12429 #13165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannager
added
the
component: data grid
GeoffreyHervet
changed the title
GeoffreyHervet
changed the title
Laloy-A
approved these changes
May 20, 2024
|
Hello, Can I do something to help for the approuval of this PR ? |
|
Hello, Can I do something to help for the approuval of this PR ? |
|
Why nobody wants to review this ? |
|
Thanks for the PR but the problem is more complex than it appears. This implementation could cause issues if the user wants control over the columns, as it could prevent user-updates from going through correctly. The root issue is that you're trying to use the grid columns in both controlled and uncontrolled mode. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As exposed in #12429, their is an issue during rerendering columns : the user column position was reset and also the columns size.
I hope it will satisfy you and will merge soon. Don't hesitate if you have any remarks.
2024-05-17-14-42-15.mp4