Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jscodeshift to 0.15.2 #12305

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Bump jscodeshift to 0.15.2 #12305

merged 5 commits into from
Jun 26, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 3, 2024

Mend Renovate

This PR contains the following updates:

Fixes #12567

Package Change Age Adoption Passing Confidence
jscodeshift 0.13.1 -> 0.15.2 age adoption passing confidence
@types/jscodeshift (source) ^0.11.5 -> ^0.11.11 age adoption passing confidence

Release Notes

facebook/jscodeshift (jscodeshift)

v0.15.2

Compare Source

Fixed

v0.15.1

Compare Source

Changed
Fixed

v0.15.0

Compare Source

Changed
Fixed

v0.14.0

Compare Source

Added
Changed
  • Bumped dependency versions
  • Allow arguments in --help to be listed in an order other than alphabetically, so they can instead be grouped thematically (#​507, @​elonvolo)
  • Allow the j shortcut in test utils (#​515, @​no23reason)

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Update of dependencies label Mar 3, 2024
@mui-bot
Copy link

mui-bot commented Mar 3, 2024

Deploy preview: https://deploy-preview-12305--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against bc0c5b0

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 4, 2024
Copy link

github-actions bot commented Mar 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@renovate renovate bot force-pushed the renovate/jscodeshift-0.x branch from 2996bdf to 4e9cb38 Compare March 4, 2024 13:25
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 4, 2024
@renovate renovate bot force-pushed the renovate/jscodeshift-0.x branch 2 times, most recently from f20f924 to d1f1ce2 Compare March 7, 2024 09:50
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 20, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@renovate renovate bot force-pushed the renovate/jscodeshift-0.x branch from d1f1ce2 to 72f50d5 Compare March 20, 2024 09:44
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 20, 2024
@renovate renovate bot force-pushed the renovate/jscodeshift-0.x branch from 72f50d5 to 0ba9d1f Compare March 20, 2024 21:55
@renovate renovate bot changed the base branch from next to master March 20, 2024 21:55
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 24, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@renovate renovate bot force-pushed the renovate/jscodeshift-0.x branch from 0ba9d1f to 6643fb7 Compare April 24, 2024 15:35
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 24, 2024
Copy link

github-actions bot commented May 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 8, 2024
@renovate renovate bot force-pushed the renovate/jscodeshift-0.x branch from 6643fb7 to f3fe2c3 Compare May 8, 2024 10:33
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 8, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 15, 2024
@renovate renovate bot force-pushed the renovate/jscodeshift-0.x branch from f3fe2c3 to 55ec6c6 Compare May 15, 2024 07:08
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 15, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 29, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@renovate renovate bot force-pushed the renovate/jscodeshift-0.x branch from 55ec6c6 to 6a5f809 Compare May 29, 2024 11:34
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 29, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@renovate renovate bot force-pushed the renovate/jscodeshift-0.x branch from 48420ac to a8ce611 Compare June 10, 2024 10:03
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 10, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 11, 2024
@renovate renovate bot force-pushed the renovate/jscodeshift-0.x branch from a8ce611 to ff78388 Compare June 11, 2024 09:23
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 11, 2024
Copy link
Contributor Author

renovate bot commented Jun 12, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 12, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 12, 2024
@MBilalShafi
Copy link
Member

MBilalShafi commented Jun 12, 2024

Following the same route as core, until the underlying issue with the recast is still there, let's not prevent our users from using latest typescript expressions like satisfies, since the parenthesis could easily be fixed with code formatters like prettier.

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this! 🙏
Core is releasing it under a new major, but in our case, this would end up in a minor/patch release. 🙈
WDYT about improving the documentation and also thinking about an informative changelog highlight to along with it.
Adding an additional runtime warning just like we already have might also be a good idea:

IMPORTANT NOTICE ABOUT CODEMOD USAGE
====================================
Not all use cases are covered by codemods. In some scenarios, like props spreading, cross-file dependencies and etc., the changes are not properly identified and therefore must be handled manually.
For example, if a codemod tries to rename a prop, but this prop is hidden with the spread operator, it won't be transformed as expected.
<DatePicker {...pickerProps} />
After running the codemods, make sure to test your application and that you don't have any console errors.

WDYT @MBilalShafi? 🤔

@LukasTy LukasTy requested a review from flaviendelangle June 12, 2024 12:49
@MBilalShafi
Copy link
Member

Core is releasing it under a new major, but in our case, this would end up in a minor/patch release. 🙈

Nice point. Do you mean it's kind-of a breaking change? It might be considered a non-breaking change, because:

  1. Prettier would still come into play after running these codemods since every project has its own formatting rules, it is less likely that the codemod output (even today's) would 100% comply with the formatting rules of a certain project.

  2. Codemods are likely to be run once per project per major release (at the time of migration), so the existing users that already ran them, might not rerun them for the same major, which would mean that combining running codemods with code formatting should solve the issues for new users running them.

  3. The existing codemod warning somehow implies the users manually double checking after running the codemods, which would reduce the chances of un-pretty code being committed.

    After running the codemods, make sure to test your application and that you don't have any console errors.

    So it's likely people are already doing this before committing the code.

Makes sense?

Adding an additional runtime warning just like we already have might also be a good idea

How about improving the existing one to accommodate this one too?

- After running the codemods, make sure to test your application and that you don't have any console errors.
+ After running the codemods, make sure to test your application and that you don't have any errors. 

Or

- After running the codemods, make sure to test your application and that you don't have any console errors.
+ After running the codemods, make sure to test your application and that you don't have any formatting or console errors. 

What do you think?

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think?

I'm sorry for the late reply @MBilalShafi.
Your comments/points make complete sense.
I do agree with all of them, I just wanted to be extra careful. 🙈 😆
But moving forward with this is more important than a few potential questions from some users. 👍

In regards to your suggestion, the second proposal for the message looks better to me. 👍

@LukasTy LukasTy enabled auto-merge (squash) June 26, 2024 07:33
@LukasTy LukasTy merged commit 2d68205 into master Jun 26, 2024
15 checks passed
@LukasTy LukasTy deleted the renovate/jscodeshift-0.x branch June 26, 2024 07:51
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Bilal Shafi <[email protected]>
Co-authored-by: Lukas <[email protected]>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Bilal Shafi <[email protected]>
Co-authored-by: Lukas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] 7.0 migration script exception
3 participants