Bump MUI Core #10604
Bump MUI Core #10604
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
Deploy preview: https://deploy-preview-10604--material-ui-x.netlify.app/ |
renovate
bot
force-pushed
the
renovate/mui-core
branch
6 times, most recently
from
dd07c1b to
daac4bd
Compare
renovate
bot
force-pushed
the
renovate/mui-core
branch
from
daac4bd to
7a63fc8
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
| @@ -189,7 +189,7 @@ async function initializeEnvironment( | |||
| await waitFor(async () => { | |||
| expect(await page.evaluate(() => document.activeElement?.textContent)).to.equal('100'); | |||
| expect(await page.evaluate(() => document.activeElement?.getAttribute('role'))).to.equal( | |||
| 'button', | |||
| 'combobox', | |||
There was a problem hiding this comment.
The role of the Select component has been changed from button to combobox with mui/material-ui#38785
cc @mui/xgrid
| @@ -623,7 +623,7 @@ describe('<DataGridPro /> - Edit components', () => { | |||
| userEvent.mousePress(screen.queryAllByRole('option')[1]); | |||
| clock.runToLast(); | |||
| expect(screen.queryByRole('listbox')).to.equal(null); | |||
| fireEvent.keyDown(screen.getByRole('button', { name: 'Adidas' }), { key: 'Enter' }); | |||
| fireEvent.keyDown(screen.getByRole('combobox'), { key: 'Enter' }); | |||
There was a problem hiding this comment.
@mui/xgrid this solves https://app.circleci.com/pipelines/github/mui/mui-x/45749/workflows/9c314f13-57ea-433a-8816-783e8ff7510f/jobs/262589
Select is no longer a button, but a combobox and name no longer work in such cases.
The component (Select) might be missing some information to expose it, but in any case, there is only one combobox, thus, omitting the explicit name in this case seems like a decent compromise. 🤔
This PR contains the following updates:
^5.0.0-beta.17->^5.0.0-beta.20^5.14.11->^5.14.14^5.0.0-beta.8->^5.0.0-beta.11^5.14.11->^5.14.14^5.14.11->^5.14.14^5.14.11->^5.14.14Release Notes
mui/material-ui (@mui/base)
v5.0.0-beta.20Compare Source
v5.0.0-beta.19Compare Source
v5.0.0-beta.18Compare Source
Configuration
📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate. View repository job log here.