Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update issue actions & templates #10375

Merged
merged 21 commits into from
Sep 25, 2023
Merged

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Sep 18, 2023

@romgrk romgrk added core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product labels Sep 18, 2023
@@ -30,7 +32,7 @@ body:

Please provide a link to a live example and an unambiguous set of steps to reproduce this bug. As a starting point, we recommend you [browse the documentation](https://mui.com/x/introduction/), and [select](https://mui.com/static/docs/forking-an-example.png) the closest example to your use case. Or you can use a [basic template](https://mui.com/r/x-issue-template) to build your reproduction case.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the time people come in with their bug case already known. Having to click on the docs, find an example, fork it, and modify it, is a lot of friction.

I would suggest that we provide from right here a set of starter templates for the different parts of X, this would make it easier for users.

One such example:

Not sure if we want to have direct CSB links or if we want links through mui.com, please let me know what's best.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a great idea.

It should reduce the pickup time by a fair margin as well, when the case is already known and can be tested against. It might also reduce a ton of misunderstanding (from my experience on past projects this happens quite a lot)

💯

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, +1 for direct codesandbox links. How do you see this exactly? 1 link per package? Any preference of codesandbox vs. StackBlitz?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes one link per package would be nice. I think CSB, we've been using that everywhere.

Copy link
Member

@oliviertassinari oliviertassinari Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the time people come in with their bug case already known. Having to click on the docs, find an example, fork it, and modify it, is a lot of friction.
I would suggest that we provide from right here a set of starter templates for the different parts of X, this would make it easier for users.

I struggle to subscribe to this narrative. The current description is:

Please provide a link to a live example and an unambiguous set of steps to reproduce this bug. As a starting point, we recommend you browse the documentation, and select the closest example to your use case. Or you can use a basic template to build your reproduction case.

The current DX feels like the proposal. As I understand it, developers either go with the basic template: https://mui.com/r/x-issue-template (say they already have a reproduction), or they go with our endless stream of templates that each docs demo. The complexity is then to find the closest template, which is the inherent problem with providing more than one template. The docs feel hard to do better on: it's 1. visual, 2. organized, and 3. kept up to date.


A side note, screenshot is outdated:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One use-case that I see quite often when I'm on support duty is the authors open their issue with their existing code pasted literally in the issue body, and we have to ask them for a live reproduction example.

One problem with the current instructions is that it's not super clear/evident that you can fork a codesandbox directly from the docs. It took me weeks to understand that when I started working here, I'm guessing it's possible a lot of people also don't realize it. I think that might be a reason why we often don't have a live example when people open issues.

In any case, I think we could provide both options? A list of direct templates, plus the instructions to the docs. I think we should also be much more explicit, something like "You are required to provide a codesandbox live example. Fork one of these templates or [docs instructions]".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a really great observation. We shouldn't take for granted that everyone is familiar with all the tools that we use.
Being more explicit is a great way, maybe not going overboard with required, but strongly encouraging it. 🤞

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reworked the message to include both of these, and shortened it a bit to make it more dynamic: result here.

@mui-bot

This comment was marked as off-topic.

@oliviertassinari oliviertassinari requested review from michelengelen and removed request for oliviertassinari September 18, 2023 09:25
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great addition to the templates! 👍🏼

@@ -30,7 +32,7 @@ body:

Please provide a link to a live example and an unambiguous set of steps to reproduce this bug. As a starting point, we recommend you [browse the documentation](https://mui.com/x/introduction/), and [select](https://mui.com/static/docs/forking-an-example.png) the closest example to your use case. Or you can use a [basic template](https://mui.com/r/x-issue-template) to build your reproduction case.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a great idea.

It should reduce the pickup time by a fair margin as well, when the case is already known and can be tested against. It might also reduce a ton of misunderstanding (from my experience on past projects this happens quite a lot)

💯

.github/ISSUE_TEMPLATE/1.bug.yml Outdated Show resolved Hide resolved
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michelengelen 💯 to move this to other repositories once successful on MUI X 💃

.github/workflows/issue-cleanup.yaml Outdated Show resolved Hide resolved
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
Seems like a worthwhile experiment.
Leaving a few nitpick comments on the grammar that could also be ignored. 🙈 🤷

.github/ISSUE_TEMPLATE/1.bug.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/1.bug.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/2.feature.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/1.bug.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/2.feature.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/4.premium-support.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/5.priority-support.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/5.priority-support.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/6.docs-feedback.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/6.docs-feedback.yml Outdated Show resolved Hide resolved
@romgrk
Copy link
Contributor Author

romgrk commented Sep 20, 2023

I've included the comments & made a few more minor adjustments. If you want to review again go ahead, this is ready on my side. You can test any of this on the test repo that mirrors this PR.

@romgrk romgrk merged commit 0ec6119 into mui:master Sep 25, 2023
5 checks passed
@romgrk romgrk deleted the core-issue-actions branch September 25, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants