Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add latest-v5 tag to v5 releases #44757

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Dec 13, 2024

By default, pnpm publish updates the latest tag: https://pnpm.io/cli/publish#--tag-tag. This means if no --tag is provided, the release will be tagged as latest. For us, this means that v5 releases were incorrectly marked as latest: #44736

Fixed by adding a latest-v5 tag. The X team does the same: https://www.npmjs.com/package/@mui/x-date-pickers?activeTab=versions.

@DiegoAndai DiegoAndai self-assigned this Dec 13, 2024
@DiegoAndai DiegoAndai added the core Infrastructure work going on behind the scenes label Dec 13, 2024
@mui-bot
Copy link

mui-bot commented Dec 13, 2024

Netlify deploy preview

https://deploy-preview-44757--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b449382

@DiegoAndai DiegoAndai merged commit c973731 into mui:v5.x Dec 13, 2024
20 of 21 checks passed
@DiegoAndai DiegoAndai deleted the add-latest-v5-tag branch December 13, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes v5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants