[material-ui][Dialog] Fix crashing of DraggableDialog demo #44747
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
docs
Netlify deploy previewhttps://deploy-preview-44747--material-ui.netlify.app/ Bundle size report |
1 task
sai6855
changed the title
Thor-x86
reviewed
Dec 12, 2024
sai6855
force-pushed
the
fix-reactdraggle
branch
from
d35d3cf to
5208e85
Compare
sai6855
commented
Dec 12, 2024
| return ( | ||
| <Draggable | ||
| nodeRef={nodeRef as React.RefObject<HTMLDivElement>} |
There was a problem hiding this comment.
nodeRef doesn't accept a null type. If null is removed from the nodeRef declaration, TypeScript throws an error in the Paper component. So i used type assertion as a workaround.
There was a problem hiding this comment.
Got it, FYI react-draggable last published version is on last year. I'm not sure if we have to wait for them to merge the PR.
There was a problem hiding this comment.
Yeah! My intention wasn't for us to wait, just to be aware of it.
aarongarciah
approved these changes
Dec 12, 2024
|
Thanks ~ @sai6855 |
|
This is now fixed on https://mui.com |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #44732
Error occurs because react-draggable is using the deprecated findDOMNode method. On updating code to use refs fixed the issue
before: https://mui.com/material-ui/react-dialog/#draggable-dialog
after: https://deploy-preview-44747--material-ui.netlify.app/material-ui/react-dialog/#draggable-dialog