Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] MUI Joy 5.0.0-beta.50 #44735

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

DiegoAndai
Copy link
Member

Release for React 19 support. Dev dependencies haven't been updated yet but that shouldn't impact end users.

I checked with pnpm release:changelog and there are no Joy-specific commits since the last release from this branch (which was alongside 5.16.1)

@DiegoAndai DiegoAndai added the release We are shipping :D label Dec 11, 2024
@DiegoAndai DiegoAndai self-assigned this Dec 11, 2024
@mui-bot
Copy link

mui-bot commented Dec 11, 2024

Netlify deploy preview

https://deploy-preview-44735--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 8a8f9a6

@DiegoAndai DiegoAndai merged commit 5dede3d into mui:v5.x Dec 11, 2024
20 checks passed
@DiegoAndai DiegoAndai deleted the release-joy-react-19 branch December 11, 2024 14:24
@beppemarazzi
Copy link

@DiegoAndai
probably you already know...
anyway the released 5.0.0-beta.50 still depends on react17 || react 18:

"peerDependencies": {
"@emotion/react": "^11.5.0",
"@emotion/styled": "^11.3.0",
"@types/react": "^17.0.0 || ^18.0.0",
"react": "^17.0.0 || ^18.0.0",
"react-dom": "^17.0.0 || ^18.0.0"
},

so it gives this error on a new react19 project:

λ  npm install @mui/joy @emotion/react @emotion/styled                                                  
npm error code ERESOLVE                                                                                 
npm error ERESOLVE unable to resolve dependency tree                                                    
npm error                                                                                               
npm error While resolving: [email protected]                                                        
npm error Found: [email protected]                                                                           
npm error node_modules/react                                                                            
npm error   react@"^19.0.0" from the root project                                                       
npm error   peer react@">=16.8.0" from @emotion/[email protected]                                           
npm error   node_modules/@emotion/react                                                                 
npm error     @emotion/react@"*" from the root project                                                  
npm error     peerOptional @emotion/react@"^11.5.0" from @mui/[email protected]                         
npm error     node_modules/@mui/joy                                                                     
npm error       @mui/joy@"*" from the root project                                                      
npm error     1 more (@emotion/styled)                                                                  
npm error   1 more (@emotion/styled)                                                                    
npm error                                                                                               
npm error Could not resolve dependency:                                                                 
npm error peer react@"^17.0.0 || ^18.0.0" from @mui/[email protected]                                   
npm error node_modules/@mui/joy                                                                         
npm error   @mui/joy@"*" from the root project                                                          
npm error                                                                                               
npm error Fix the upstream dependency conflict, or retry                                                
npm error this command with --force or --legacy-peer-deps                                               
npm error to accept an incorrect (and potentially broken) dependency resolution.                        

the latest version of packages/mui-joy/package.json fixed it:

"peerDependencies": {
"@emotion/react": "^11.5.0",
"@emotion/styled": "^11.3.0",
"@types/react": "^17.0.0 || ^18.0.0 || ^19.0.0",
"react": "^17.0.0 || ^18.0.0 || ^19.0.0",
"react-dom": "^17.0.0 || ^18.0.0 || ^19.0.0"
},

is a beta.51 release planned soon?

for anyone hitting this issue, meanwhile I'm using an override in my package.json:

"overrides": {
    "COMMENT_@mui/joy": "@mui/[email protected] supports react 19 but still have peer dependencies on react 18...",
    "@mui/joy":{
      "@types/react": "^19",
      "@types/react-dom": "^19",
      "react": "^19",
      "react-dom": "^19"
    }
  }

@DiegoAndai
Copy link
Member Author

DiegoAndai commented Dec 12, 2024

Hey @beppemarazzi, thanks for reaching out. We're working out the last details for fixing the peer dependencies. It should be available soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release We are shipping :D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants