[Select] Set aria-required & aria-invalid on combobox instead of hidden input
#44731
+38
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-44731--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
ben-pomelo
changed the title
ben-pomelo
changed the title
mj12albert
added
accessibility
mj12albert
changed the title
aria-required & aria-invalid on combobox instead of hidden input
mj12albert
reviewed
Dec 12, 2024
There was a problem hiding this comment.
@ben-pomelo Thanks for working on this ~
Would you mind also adding a simple test each for aria-required/aria-invalid here as well (highlighted lines as a reference)
|
@mj12albert Thanks for pointing me to the tests, I added a few tests, including:
PTAL! |
…ombobox div to fix accessibility issues.
ben-pomelo
force-pushed
the
select-sets-aria-required
branch
from
8d4a9a7 to
17e2574
Compare
…ould be the same behavior, but cleaner html
ben-pomelo
force-pushed
the
select-sets-aria-required
branch
from
17e2574 to
522d09f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #44740 which causes the screen reader to fail to identify Select components that are "Required" or are in an error state.
With this fix, this is what the screen reader reports:
