-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Add support for data attributes in the API generation #44709
Changes from 6 commits
ed66b6a
876fad0
2f1c080
0eafaa0
b93224e
85a87fc
86cc3f3
fd11e17
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ export interface Slot { | |
default?: string; | ||
} | ||
|
||
export interface CssVariable { | ||
export interface ApiItemDescription { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Made the name more generic to be reused with different types of API descriptions. |
||
name: string; | ||
description: string; | ||
} | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,13 @@ | ||||||
enum AccordionDataAttributes { | ||||||
/** | ||||||
* Indicates whether the panel is opened | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Side note, I was thinking of making a quick PR to fail the CI anytime any of those descriptions doesn't end with a dot. I suspect it's a quick win. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am reverting these changes, they are just here to help the reviewer :) |
||||||
*/ | ||||||
panelOpen = '[data-panel-open]', | ||||||
/** | ||||||
* Indicates how many dialogs are nested within. | ||||||
* @type {number} | ||||||
*/ | ||||||
nestedDialogs = '[data-nested-dialogs]', | ||||||
} | ||||||
|
||||||
export default AccordionDataAttributes; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repurposed the function to be used with any attribute