Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix popper in autocomplete demo overlaps the documentation navbar #43495

Closed
wants to merge 3 commits into from
Closed

[docs] Fix popper in autocomplete demo overlaps the documentation navbar #43495

wants to merge 3 commits into from

Conversation

Michael-Hutchinson
Copy link
Contributor

@Michael-Hutchinson Michael-Hutchinson commented Aug 28, 2024

fix: Add zIndex to DemoRootMaterial and DemoRootJoy components to fix issue where the nav is overlapping

Closes 43462

Before: https://mui.com/material-ui/react-autocomplete/
After: https://deploy-preview-43495--material-ui.netlify.app/material-ui/react-autocomplete/

@mui-bot
Copy link

mui-bot commented Aug 28, 2024

Netlify deploy preview

https://deploy-preview-43495--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f56430f

@zannager zannager added docs Improvements or additions to the documentation component: Popper The React component. See <Popup> for the latest version. labels Aug 28, 2024
@zannager zannager requested a review from mj12albert August 28, 2024 11:55
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Popper in autocomplete demo overlaps the navbar [docs] Fix popper in autocomplete demo overlaps the navbar Aug 31, 2024
@ZeeshanTamboli ZeeshanTamboli added enhancement This is not a bug, nor a new feature and removed component: Popper The React component. See <Popup> for the latest version. labels Aug 31, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Fix popper in autocomplete demo overlaps the navbar [docs] Fix popper in autocomplete demo overlaps the documentation navbar Aug 31, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fix the issue. It only works for the first demo, not for the rest of the demos, because each has a different stacking context. Also, the fix isn't needed. See #43462 (comment).

@ZeeshanTamboli ZeeshanTamboli removed the enhancement This is not a bug, nor a new feature label Aug 31, 2024
@Michael-Hutchinson Michael-Hutchinson deleted the fix/popper-in-demo-overlaps-nav branch August 31, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Popper in Autocomplete demos have higher z-index than the site's nav elements
4 participants