[material-ui][Accordion] Improve slots.transition type #42993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
added
typescript
component: accordion
Netlify deploy previewBundle size report |
aarongarciah
commented
Jul 19, 2024
| TransitionComponent?: React.JSXElementConstructor< | ||
| TransitionProps & { children?: React.ReactElement<any, any> } | ||
| TransitionComponent?: React.ElementType< | ||
| TransitionProps & { children: React.ReactElement<any, any> } |
There was a problem hiding this comment.
We are doing this in at least these components:
We could also improve the type by either:
- Make
childrenrequired inTransitionProps, but that would require more changes and there are places wherechildrenprobably is not required. - Update transition components and make
childrenoptional. Again, that means more changes.
There was a problem hiding this comment.
I agree with you: when we make the change we should be consistent with it. At this point, because it's not a pressing issue (there's no users requests for it), I'm thinking we should:
- Update the original issue to include all the components in the scope
- Take it out of v6's scope
This way we avoid the unrelated breaking change of a non urgent issue.
What do you think?
There was a problem hiding this comment.
Makes sense. I'll update the issue and remove it from the v6 milestone.
aarongarciah
changed the title
aarongarciah
force-pushed
the
accordion-transition-children-type
branch
from
eebfa05 to
7663a21
Compare
aarongarciah
force-pushed
the
accordion-transition-children-type
branch
from
7663a21 to
0f34fc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #40650