Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui] Fix Accessing element.ref #42818

Merged
merged 13 commits into from
Jul 18, 2024
Merged

[material-ui] Fix Accessing element.ref #42818

Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3ecc332
fix
sai6855 Jul 2, 2024
916c3a5
fix
sai6855 Jul 2, 2024
9ee9592
fix tests
sai6855 Jul 2, 2024
117305f
add getChildRef util
sai6855 Jul 3, 2024
e781158
show diego react error
sai6855 Jul 3, 2024
a8e9190
Revert "show diego react error"
sai6855 Jul 3, 2024
ec910e5
add getChildRef d.ts file
sai6855 Jul 3, 2024
1d5f95d
handle chidlren edge cases
sai6855 Jul 3, 2024
7fa5eda
fix type
sai6855 Jul 3, 2024
2f926cd
update getChildRef logic
sai6855 Jul 3, 2024
5bc21fa
rename children to child
sai6855 Jul 7, 2024
916818e
remove checking child count
sai6855 Jul 7, 2024
95a319b
fix comment
sai6855 Jul 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/mui-material/src/Tooltip/Tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,10 @@ const Tooltip = React.forwardRef(function Tooltip(inProps, ref) {
};
}, [handleClose, open]);

const handleRef = useForkRef(children.ref, setChildNode, ref);
// 'ref' is passed as prop in React 19, whereas 'ref' is directly attached to children in React 18
// below check is to ensure 'ref' is accessible in both cases
const childRef = Object.keys(children.props).includes('ref') ? children.props.ref : children.ref;
oliviertassinari marked this conversation as resolved.
Show resolved Hide resolved
const handleRef = useForkRef(childRef, setChildNode, ref);

// There is no point in displaying an empty tooltip.
// So we exclude all falsy values, except 0, which is valid.
Expand Down
Loading