Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Badge] Deprecate components and componentsProps #41655

Merged
merged 6 commits into from
Mar 26, 2024
Merged

[material-ui][Badge] Deprecate components and componentsProps #41655

merged 6 commits into from
Mar 26, 2024

Conversation

skmanoj322
Copy link
Contributor

@skmanoj322 skmanoj322 commented Mar 26, 2024

Hey @DiegoAndai sorry for troubles due to lot of merge conflit i had to create new pr 🙏 .

part of #40417

@mui-bot
Copy link

mui-bot commented Mar 26, 2024

@mnajdova mnajdova changed the title [material-ui][badge] Recreated the pr . [material-ui][Badge] Deprecate components and componentsProps Mar 26, 2024
@zannager zannager added the component: badge This is the name of the generic UI component, not the React module! label Mar 26, 2024
@zannager zannager requested a review from DiegoAndai March 26, 2024 13:04
@danilo-leal danilo-leal added the package: material-ui Specific to @mui/material label Mar 26, 2024
Signed-off-by: Diego Andai <[email protected]>
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge 🚀

@skmanoj322 I'm sorry I was late to reply, thanks for working on this 🙌🏼

@skmanoj322
Copy link
Contributor Author

Ready to merge 🚀

@skmanoj322 I'm sorry I was late to reply, thanks for working on this 🙌🏼

@DiegoAndai thanks for your support my first open source contribution. means a lot

packages/mui-codemod/README.md Outdated Show resolved Hide resolved
packages/mui-codemod/README.md Outdated Show resolved Hide resolved
packages/mui-codemod/README.md Outdated Show resolved Hide resolved
Signed-off-by: Diego Andai <[email protected]>
@DiegoAndai
Copy link
Member

@skmanoj322, you're welcome! hopefully, you can continue contributing to this or other projects in the future.

@DiegoAndai DiegoAndai merged commit 8e37d2b into mui:next Mar 26, 2024
22 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 29, 2024
tejasparkar pushed a commit to tejasparkar/material-ui that referenced this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: badge This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants