Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base-ui][MenuItem] added disableCloseOnClick prop #40873

Conversation

Jaswanth-Sriram-Veturi
Copy link
Contributor

closes: mui/base-ui#46

@mui-bot
Copy link

mui-bot commented Jan 31, 2024

Netlify deploy preview

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 03c6e28

@Jaswanth-Sriram-Veturi Jaswanth-Sriram-Veturi marked this pull request as draft January 31, 2024 14:33
@Jaswanth-Sriram-Veturi Jaswanth-Sriram-Veturi changed the title [base-ui][useMenuItem] added disableCloseOnClick prop to useMenuItem hook [base-ui][MenuItem] added disableCloseOnClick prop Jan 31, 2024
@Jaswanth-Sriram-Veturi Jaswanth-Sriram-Veturi marked this pull request as ready for review January 31, 2024 16:11
@zannager zannager added component: menu This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Feb 1, 2024
@zannager zannager requested a review from mnajdova February 1, 2024 15:54
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks OK.
Please add a few words about this functionality in the docs (/docs/data/base/components/menu/menu.md)

packages/mui-base/src/useMenuItem/useMenuItem.test.tsx Outdated Show resolved Hide resolved
@michaldudak
Copy link
Member

We recently moved the development of the Base UI to a separate repository: https://github.com/mui/base-ui. We're pausing accepting external contributions until we complete the planned API change. After these changes are done, we will port this PR to the new repo.

Thanks for your contribution anyway!

@michaldudak michaldudak added the port-to-base-ui PR to be included in the Base UI repository once the API changes are done label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base port-to-base-ui PR to be included in the Base UI repository once the API changes are done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Menu] Configure MenuItems not to close the Menu when clicked
4 participants