[material-ui][PaginationItem] Deprecate composed classes for v6 #40673
Conversation
sai6855
added
deprecation
Netlify deploy previewhttps://deploy-preview-40673--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
There was a problem hiding this comment.
Looks good! Only had a small comment.
I also think we could standardize the type classes (in a separate PR) I'm thinking deprecating:
firstLastfortypeFirst,typeLastpreviousNextfortypePrevious,typeLastellipsisfortypeStartEllipsis,typeEndEllipsispagefortypePage
Although that's to be a lot of classes 😅
What do you think? @mui/core I would like to hear your opinion as well 😊
| @@ -41,6 +41,7 @@ const useUtilityClasses = (ownerState) => { | |||
| `size${capitalize(size)}`, | |||
| variant, | |||
| shape, | |||
| ['primary', 'secondary'].includes(color) && `color${capitalize(color)}`, | |||
There was a problem hiding this comment.
I think we should do
| ['primary', 'secondary'].includes(color) && `color${capitalize(color)}`, | |
| color !== 'standard' && `color${capitalize(color)}`, |
As the logic is "add a color* class for all color values except the default"
There was a problem hiding this comment.
got it!! fixed in this commit 84f7045
oliviertassinari
changed the title
|
I updated the PR title to be clearer and match the other PRs. My first assumption reading the title was a deprecation of the |
part of #40417
new classes: primary , secondary
preview: https://deploy-preview-40673--material-ui.netlify.app/material-ui/api/pagination-item/#classes