Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base-ui][Modal] Refine demos #39824

Merged
merged 11 commits into from
Nov 22, 2023
Merged

[base-ui][Modal] Refine demos #39824

merged 11 commits into from
Nov 22, 2023

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Nov 9, 2023 •
edited by danilo-leal
Loading

Follow-up to #38820

This PR fixes the nested button's active state and some other stray design tweaks.
👉 https://deploy-preview-39824--material-ui.netlify.app/base-ui/react-modal/

@zanivan zanivan added component: modal This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer package: base-ui Specific to @mui/base labels Nov 9, 2023
@zanivan zanivan self-assigned this Nov 9, 2023
@mui-bot
Copy link

mui-bot commented Nov 9, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39824--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 428509c

@zannager zannager requested a review from michaldudak November 10, 2023 13:18
@zanivan zanivan requested a review from danilo-leal November 10, 2023 13:47
danilo-leal
danilo-leal reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just dropping in a few tiny polish comments. 🤙

docs/data/base/components/modal/ServerModal.js Outdated Show resolved Hide resolved
docs/data/base/components/modal/ServerModal.js Show resolved Hide resolved
docs/data/base/components/modal/ServerModal.js Show resolved Hide resolved
docs/data/base/components/modal/ServerModal.js Outdated Show resolved Hide resolved
docs/data/base/components/modal/ServerModal.js Outdated Show resolved Hide resolved
docs/data/base/components/modal/ServerModal.js Outdated Show resolved Hide resolved
danilo-leal
danilo-leal approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good design-wise! 🤙

@zanivan zanivan merged commit 484ef32 into mui:master Nov 22, 2023
20 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 30, 2023
@zanivan @mnajdova
[base-ui][Modal] Refine demos (mui#39824)
7206a0a
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 1, 2023
@zanivan @mnajdova
[base-ui][Modal] Refine demos (mui#39824)
3271fc5
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 1, 2023
@zanivan @mnajdova
[base-ui][Modal] Refine demos (mui#39824)
82b3119
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
@zanivan @mnajdova
[base-ui][Modal] Refine demos (mui#39824)
9bd940c
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
@zanivan @mnajdova
[base-ui][Modal] Refine demos (mui#39824)
f3d6e66
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
@zanivan @mnajdova
[base-ui][Modal] Refine demos (mui#39824)
c716174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova left review comments

@danilo-leal danilo-leal danilo-leal approved these changes

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees

@zanivan zanivan

Labels
component: modal This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zanivan @mui-bot @mnajdova @michaldudak @danilo-leal