Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base-ui][Slider] Refine demos #39526

Merged
merged 9 commits into from
Oct 20, 2023
Merged

[base-ui][Slider] Refine demos #39526

merged 9 commits into from
Oct 20, 2023

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Oct 19, 2023

Follow-up to #38820

Standardize the focus-visible on all Base UI Slider demos.

@zanivan zanivan added component: slider This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer package: base-ui Specific to @mui/base labels Oct 19, 2023
@zanivan zanivan self-assigned this Oct 19, 2023
@mui-bot
Copy link

mui-bot commented Oct 19, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39526--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f51a5b9

danilo-leal

This comment was marked as resolved.

Sign in to view

danilo-leal

This comment was marked as resolved.

Sign in to view

@zanivan zanivan requested a review from danilo-leal October 19, 2023 18:08
@zanivan zanivan changed the title [base-ui][Slider] Standardize focus-visible on demos [base-ui][Slider] Refine hover, focus and active style on demos Oct 20, 2023
@zanivan zanivan changed the title [base-ui][Slider] Refine hover, focus and active style on demos [base-ui][Slider] Refine demos Oct 20, 2023
danilo-leal
danilo-leal approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice! 👌

@zanivan zanivan merged commit e00fa56 into mui:master Oct 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees

@zanivan zanivan

Labels
component: slider This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanivan @mui-bot @danilo-leal