Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base-ui][Autocomplete] Standardize box shadow on demos #39519

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Oct 19, 2023

Follow-up to #38820

Standardize the box-shadow on all Base UI Autocomplete demos.

👉 https://deploy-preview-39519--material-ui.netlify.app/base-ui/react-autocomplete/

@zanivan zanivan added component: select This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer package: base-ui Specific to @mui/base labels Oct 19, 2023
@zanivan zanivan self-assigned this Oct 19, 2023
@mui-bot
Copy link

mui-bot commented Oct 19, 2023

Netlify deploy preview

https://deploy-preview-39519--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 5197510

@zanivan
Copy link
Contributor Author

zanivan commented Oct 19, 2023

The dark theme bug from #38575 might be happening here on the introduction demo, or maybe it's just something wrong with Tailwind styling? Could you please take a look @danilo-leal @mnajdova @michaldudak ?

Screenshot 2023-10-19 at 11 38 44

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll leave it tentatively approved, as aside from these tiny Tailwind box-shadow declaration fixes and the bug above (which indeed seems like a bug), everything's good!

zanivan and others added 2 commits October 20, 2023 13:00
Co-authored-by: Danilo Leal <[email protected]>
Signed-off-by: Victor Zanivan Monteiro <[email protected]>
Co-authored-by: Danilo Leal <[email protected]>
Signed-off-by: Victor Zanivan Monteiro <[email protected]>
@zanivan zanivan merged commit d9dcb55 into mui:master Oct 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants