Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base-ui][select] Standardize box shadow on demos #39509

Merged
merged 2 commits into from
Oct 19, 2023
Merged

[base-ui][select] Standardize box shadow on demos #39509

merged 2 commits into from
Oct 19, 2023

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Oct 18, 2023 •
edited by danilo-leal
Loading

Follow-up to #38820

Standardize the box-shadow on all Base UI Select demos.

👉 https://deploy-preview-39509--material-ui.netlify.app/base-ui/react-select/

@zanivan zanivan added component: select This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer package: base-ui Specific to @mui/base labels Oct 18, 2023
@zanivan zanivan self-assigned this Oct 18, 2023
@zanivan zanivan requested a review from danilo-leal October 18, 2023 20:35
@mui-bot
Copy link

mui-bot commented Oct 18, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39509--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 9f883a4

danilo-leal
danilo-leal approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Love the polish and standardization 🤙 Not necessarily for this PR — and it might be something already tackled on the main design review one — but make sure all input-like component has the same box shadow styles, too!

@zanivan
Copy link
Contributor Author

zanivan commented Oct 19, 2023

make sure all input-like component has the same box shadow styles, too!

Yep, sure thing! I'm tackling one component at a time—learned from #38820 that things can get huge, so better do one step at the time 😅

@zanivan zanivan merged commit c3e3f0d into mui:master Oct 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees

@zanivan zanivan

Labels
component: select This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer package: base-ui Specific to @mui/base
Projects
Base UI Alpha
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanivan @mui-bot @danilo-leal