Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Pagination] Update type parameter of getItemAriaLabel prop #39390

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

Simer13
Copy link
Contributor

@Simer13 Simer13 commented Oct 11, 2023

This gives a solution to fix #39063 issue to correct the type parameter of getItemAriaLabel in the Pagination section.

This gives a solution to fix mui#39063 issue to correct the type parameter of getItemAriaLabel in the Pagination section.
@mui-bot
Copy link

mui-bot commented Oct 11, 2023

Netlify deploy preview

https://deploy-preview-39390--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 1df38ba

@Simer13 Simer13 changed the title Update Pagination.t.ds #39063 [Pagination] Update Pagination.t.ds #39063 Oct 11, 2023
@danilo-leal danilo-leal changed the title [Pagination] Update Pagination.t.ds #39063 [material-ui][Pagination] Update Pagination.t.ds Oct 11, 2023
@danilo-leal danilo-leal added package: material-ui Specific to @mui/material component: pagination This is the name of the generic UI component, not the React module! labels Oct 11, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Pagination] Update Pagination.t.ds [material-ui][Pagination] Update type parameter of getItemAriaLabel Oct 11, 2023
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work typescript labels Oct 11, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Pagination] Update type parameter of getItemAriaLabel [material-ui][Pagination] Update type parameter of getItemAriaLabel Oct 11, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Pagination] Update type parameter of getItemAriaLabel [material-ui][Pagination] Update type parameter of getItemAriaLabel prop Oct 11, 2023
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for your first contribution to MUI. Looking forward for more.

@ZeeshanTamboli ZeeshanTamboli merged commit 604d819 into mui:master Oct 11, 2023
11 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 13, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 13, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: pagination This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pagination] getItemAriaLabel is called with a wrong page type: end-ellipsis
4 participants