-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Pagination] Update type
parameter of getItemAriaLabel
prop
#39390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives a solution to fix mui#39063 issue to correct the type parameter of getItemAriaLabel in the Pagination section.
Netlify deploy previewhttps://deploy-preview-39390--material-ui.netlify.app/ Bundle size report |
Simer13
changed the title
Update Pagination.t.ds #39063
[Pagination] Update Pagination.t.ds #39063
Oct 11, 2023
danilo-leal
changed the title
[Pagination] Update Pagination.t.ds #39063
[material-ui][Pagination] Update Pagination.t.ds
Oct 11, 2023
danilo-leal
added
package: material-ui
Specific to @mui/material
component: pagination
This is the name of the generic UI component, not the React module!
labels
Oct 11, 2023
ZeeshanTamboli
changed the title
[material-ui][Pagination] Update Pagination.t.ds
[material-ui][Pagination] Update type parameter of Oct 11, 2023
getItemAriaLabel
ZeeshanTamboli
changed the title
[material-ui][Pagination] Update type parameter of
[material-ui][Pagination] Update Oct 11, 2023
getItemAriaLabel
type
parameter of getItemAriaLabel
ZeeshanTamboli
changed the title
[material-ui][Pagination] Update
[material-ui][Pagination] Update Oct 11, 2023
type
parameter of getItemAriaLabel
type
parameter of getItemAriaLabel
prop
ZeeshanTamboli
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for your first contribution to MUI. Looking forward for more.
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 13, 2023
…l` prop (mui#39390) Co-authored-by: ZeeshanTamboli <[email protected]>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 13, 2023
…l` prop (mui#39390) Co-authored-by: ZeeshanTamboli <[email protected]>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 13, 2023
…l` prop (mui#39390) Co-authored-by: ZeeshanTamboli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: pagination
This is the name of the generic UI component, not the React module!
package: material-ui
Specific to @mui/material
typescript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives a solution to fix #39063 issue to correct the type parameter of getItemAriaLabel in the Pagination section.