Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix Code Sandbox download issue #39317

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

ARJ2160
Copy link
Contributor

@ARJ2160 ARJ2160 commented Oct 5, 2023

Preview: https://deploy-preview-39317--material-ui.netlify.app/material-ui/react-alert/#basic-alerts
Closes #38860

Before After
image image

Also, I think the issue has also fixed the problem where you navigate to the docker tab and convert to a cloud sandbox.
image

Thank you so much @Janpot, your suggestion was very helpful and was enough to solve the problem

@mui-bot
Copy link

mui-bot commented Oct 5, 2023

Netlify deploy preview

https://deploy-preview-39317--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 38ade23

@Janpot
Copy link
Member

Janpot commented Oct 5, 2023

Thank you, a few things I noticed so far:

  • When clicking the codesandbox link, the current implementation opens the /Demo.tsx file. The implementation of this PR opens the /src/index.tsx file. I believe it should open the /src/Demo.tsx file instead.
  • You'll have to look into the tests, some of them seem to be failing because of this change. (You can ignore the visual regression, it's out of the scope of this PR)

@ARJ2160
Copy link
Contributor Author

ARJ2160 commented Oct 5, 2023

Thank you @Janpot for pointing that out. These commits should fix these issues!
Change Log ->

  1. The failing tests are fixed
  2. The "Open in Code Sandbox" link opens up the "/src/Demo" file as before

@danilo-leal danilo-leal changed the title ISSUE#38860 | Unable to download codesandbox [docs-infra] Fix Code Sandbox download issue Oct 5, 2023
@danilo-leal danilo-leal added the scope: docs-infra Specific to the docs-infra product label Oct 5, 2023
@ARJ2160
Copy link
Contributor Author

ARJ2160 commented Oct 5, 2023

One of the tests is failing due to a network error. Could you please run them again?

@mnajdova mnajdova added scope: docs-infra Specific to the docs-infra product and removed scope: docs-infra Specific to the docs-infra product labels Oct 5, 2023
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Oct 8, 2023
@oliviertassinari
Copy link
Member

Ah nice, I fixed an issue recently, facing a similar pain: #37830

@danilo-leal danilo-leal merged commit 18d087f into mui:master Oct 9, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs-infra] Unable to download codesandbox
6 participants