-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Fix Code Sandbox download issue #39317
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-39317--material-ui.netlify.app/ Bundle size report |
Thank you, a few things I noticed so far:
|
Thank you @Janpot for pointing that out. These commits should fix these issues!
|
danilo-leal
changed the title
ISSUE#38860 | Unable to download codesandbox
[docs-infra] Fix Code Sandbox download issue
Oct 5, 2023
One of the tests is failing due to a network error. Could you please run them again? |
mnajdova
added
scope: docs-infra
Specific to the docs-infra product
and removed
scope: docs-infra
Specific to the docs-infra product
labels
Oct 5, 2023
Janpot
approved these changes
Oct 5, 2023
Ah nice, I fixed an issue recently, facing a similar pain: #37830 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-39317--material-ui.netlify.app/material-ui/react-alert/#basic-alerts
Closes #38860
Also, I think the issue has also fixed the problem where you navigate to the docker tab and convert to a cloud sandbox.
Thank you so much @Janpot, your suggestion was very helpful and was enough to solve the problem