Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Accessibility in Base UI #39264

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Oct 2, 2023

Described how Base UI components are accessible and what the developers need to do on their side when building applications.

@samuelsycamore, feel free to edit or expand where you feel necessary.

Closes #38539

👉 https://deploy-preview-39264--material-ui.netlify.app/base-ui/getting-started/accessibility/

@michaldudak michaldudak added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Oct 2, 2023
@mui-bot
Copy link

mui-bot commented Oct 2, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 68f003d

Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Michał Dudak <[email protected]>
@michaldudak michaldudak marked this pull request as ready for review October 5, 2023 14:01
@michaldudak
Copy link
Member Author

@samuelsycamore, thanks for your corrections! I included all of them.
Could you do the final review, please?

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this PR! This page is super important 😊 Left a few considerations about adding demos to illustrate the concepts we described — avoiding the page feeling like a wall of text.

@michaldudak
Copy link
Member Author

@danilo-leal, I added the demos. They may need to be updated after #38820 is merged in.

@samuelsycamore
Copy link
Contributor

Love the demos! They do a great job of driving home the key points.

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo, this is great! Lovely addition to the Base UI docs 🤙

@danilo-leal danilo-leal merged commit a0e59e9 into mui:master Oct 16, 2023
6 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 17, 2023
Signed-off-by: Michał Dudak <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Co-authored-by: Danilo Leal <[email protected]>
@michaldudak michaldudak deleted the base-a11y-docs branch October 27, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs][base-ui] Create a page about a11y support
4 participants