[Pagination] Fix background color on hover and keyboard focus when using CSS theme variables #39220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…change to slight dark when hovered
Netlify deploy previewhttps://deploy-preview-39220--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
danilo-leal
changed the title
danilo-leal
added
package: material-ui
mj12albert
requested review from
ZeeshanTamboli
and removed request for
mnajdova
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
ZeeshanTamboli
approved these changes
Oct 5, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 9, 2023
…ing CSS theme variables (mui#39220) Co-authored-by: ZeeshanTamboli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38944
Fixes the background color of the default pagination component to change to slightly dark when hovered.
Before: https://codesandbox.io/s/nervous-chaplygin-jg76jc?file=/src/mui-theme/ThemeProvider.tsx:190-201
After: https://codesandbox.io/s/keen-pare-8yrw7n?file=/src/mui-theme/ThemeProvider.tsx