Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Box] Add missing logical spacing property types #39169

Merged
merged 4 commits into from
Sep 27, 2023
Merged

[Box] Add missing logical spacing property types #39169

merged 4 commits into from
Sep 27, 2023

Conversation

Semigradsky
Copy link
Contributor

@Semigradsky Semigradsky commented Sep 26, 2023 •
edited by ZeeshanTamboli
Loading

Fixes #39168

@mui-bot
Copy link

mui-bot commented Sep 26, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39169--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 60e0f7e

@ZeeshanTamboli ZeeshanTamboli added the package: system Specific to @mui/system label Sep 26, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title fix(Box): Allow to use logical spacing properties [Box] Allow to use logical spacing properties with TypeScript Sep 26, 2023
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work typescript component: Box The React component. labels Sep 26, 2023
@zannager zannager requested a review from mnajdova September 26, 2023 15:14
@ZeeshanTamboli ZeeshanTamboli changed the title [Box] Allow to use logical spacing properties with TypeScript [Box] Add missing logical spacing properties type Sep 27, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [Box] Add missing logical spacing properties type [Box] Add missing logical spacing properties types Sep 27, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [Box] Add missing logical spacing properties types [Box] Add missing logical spacing property types Sep 27, 2023
ZeeshanTamboli
ZeeshanTamboli approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks!

@ZeeshanTamboli ZeeshanTamboli merged commit 0be321e into mui:master Sep 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: Box The React component. package: system Specific to @mui/system typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Box] Can't use logical spacing properties
3 participants
@Semigradsky @mui-bot @ZeeshanTamboli