Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drawer] Add missing JoyDrawer in theme components #39074

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

Studio384
Copy link
Contributor

Fixes #39041

Sorry, something went wrong.

@mui-bot
Copy link

mui-bot commented Sep 20, 2023

Netlify deploy preview

https://deploy-preview-39074--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 19ed943

@zannager zannager added component: drawer This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Sep 20, 2023
@zannager zannager requested a review from mnajdova September 20, 2023 16:03
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Studio384 Could you add the typings check to extendTheme.spec.tsx as well? follow the file convention.

@Studio384
Copy link
Contributor Author

Studio384 commented Sep 22, 2023

Not sure what the rules are for what should be set in defaultProps in the spec, so I only added the default variant and color. Also fixes the DrawerSlot type.

@@ -4,7 +4,7 @@ import { ColorPaletteProp, VariantProp, ApplyColorInversion } from '../styles/ty
import { ModalOwnProps } from '../Modal';
import { CreateSlotsAndSlotProps, SlotProps } from '../utils/types';

export type DrawerSlot = 'root' | 'label' | 'action' | 'startDecorator' | 'endDecorator';
export type DrawerSlot = 'root' | 'backdrop' | 'content';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the fix!

@ZeeshanTamboli ZeeshanTamboli changed the title [joy-ui][drawer] JoyDrawer missing in Components<Theme> [Drawer] Add missing JoyDrawer in theme components Sep 26, 2023
@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label Sep 26, 2023
@ZeeshanTamboli ZeeshanTamboli merged commit 59d4e52 into mui:master Sep 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: drawer This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[joy-ui][drawer] JoyDrawer missing in Components<Theme>
5 participants