-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Drawer] Add missing JoyDrawer
in theme components
#39074
[Drawer] Add missing JoyDrawer
in theme components
#39074
Conversation
Netlify deploy previewhttps://deploy-preview-39074--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Studio384 Could you add the typings check to extendTheme.spec.tsx
as well? follow the file convention.
Not sure what the rules are for what should be set in |
@@ -4,7 +4,7 @@ import { ColorPaletteProp, VariantProp, ApplyColorInversion } from '../styles/ty | |||
import { ModalOwnProps } from '../Modal'; | |||
import { CreateSlotsAndSlotProps, SlotProps } from '../utils/types'; | |||
|
|||
export type DrawerSlot = 'root' | 'label' | 'action' | 'startDecorator' | 'endDecorator'; | |||
export type DrawerSlot = 'root' | 'backdrop' | 'content'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for the fix!
JoyDrawer
missing in Components<Theme>
JoyDrawer
in theme components
Fixes #39041